Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V14: Fix FIXMEs #15869

Merged
merged 8 commits into from Mar 14, 2024
Merged

V14: Fix FIXMEs #15869

merged 8 commits into from Mar 14, 2024

Conversation

Zeegaan
Copy link
Member

@Zeegaan Zeegaan commented Mar 12, 2024

Notes

  • There was a FIXME in DenyLocalLoginHandler, this should now be resolved 😁

How to test

  • Assert that you can login and out of the backoffice.

@Zeegaan
Copy link
Member Author

Zeegaan commented Mar 12, 2024

I am unsure if this was the correct way to do it, as the other implementation overwrote the IsAuthorized 🤔

@elit0451
Copy link
Member

The way to test it is to set isDenied = true; in DenyLocalLoginHandler and verify that you will not be allowed to login (you'll get unauthorized); when it is false, the login/swagger auth should work as normal. We also verified that you can signout - we were getting 401 with the new changes.

@Zeegaan
Copy link
Member Author

Zeegaan commented Mar 14, 2024

Thanks for the assistance on this one @elit0451 🙌 🎉

@Zeegaan Zeegaan merged commit 9c3bc4a into v14/dev Mar 14, 2024
5 of 7 checks passed
@Zeegaan Zeegaan deleted the v14/feature/update-denylocalloginhandler branch March 14, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elit0451 elit0451 elit0451 approved these changes

Assignees
No one assigned
Labels
release/14.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Zeegaan @elit0451 @bergmania