Relations/types mangement api cleanup #15910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 19, 2024 13:25
added 3 commits
March 22, 2024 11:09
Since types are only managed trough code.
Brought RelationType responsemodels more in line with similar models Update openapi spec
4 tasks
kjac
reviewed
Mar 26, 2024
src/Umbraco.Cms.Api.Management/Controllers/RelationType/AllRelationTypeTreeController.cs
Outdated
Show resolved
Hide resolved
kjac
reviewed
Mar 26, 2024
| @@ -14,7 +14,6 @@ internal static IUmbracoBuilder AddRelationTypes(this IUmbracoBuilder builder) | |||
| .Add<RelationTypeViewModelsMapDefinition>(); | |||
|
|
|||
| builder.Services.AddTransient<IObjectTypePresentationFactory, ObjectTypePresentationFactory>(); | |||
| builder.Services.AddTransient<IRelationTypePresentationFactory, RelationTypePresentationFactory>(); | |||
kjac
reviewed
Mar 26, 2024
src/Umbraco.Cms.Api.Management/ViewModels/Relation/RelationReferenceModel.cs
Outdated
Show resolved
Hide resolved
kjac
reviewed
Mar 26, 2024
src/Umbraco.Cms.Api.Management/ViewModels/Relation/RelationResponseModel.cs
Outdated
Show resolved
Hide resolved
# Conflicts: # src/Umbraco.Cms.Api.Management/Factories/IRelationTypePresentationFactory.cs # src/Umbraco.Cms.Api.Management/Factories/RelationTypePresentationFactory.cs # src/Umbraco.Cms.Api.Management/OpenApi.json Updated openapi spec Merge fixed RelationTypesBuilderExtensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Relation types are only useful if they are used to create relations with. Creating relations of new types requires new code to actually do it. Deleting a type that is actively used by code might cause issues => Do CUD operations trough migrations
Relation types are not nestable, no need to show a path
Relation types are not nestable, so no need for tree support (more like languages)
=> added get all endpoint with paging
This was only used to determine what the original parent was trough a specific relation type, it has since been internalized into /umbraco/management/api/v1/recycle-bin/document/{id}/original-parent
Is now more inline with other models that have references to other things. Also added the type of relation returned
Testing
Make sure the remaining endpoints still work.