Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure correct access to all manifests + introduce "public" package manifests #15921

Merged
merged 3 commits into from Mar 21, 2024

Conversation

kjac
Copy link
Contributor

@kjac kjac commented Mar 21, 2024

Prerequisites

  • I have added steps to test this contribution in the description below

Description

Currently the editor needs access to the packages section in order to load package manifests. This won't do, because everyone with access to the backoffice potentially has to load package manifests.

Also, we need publicly available manifests, i.e. manifests that are allowed to load without backoffice access. These are necessary to power customizations of the login screen. It must be an explicit opt-in to be a "public" manifest.

Example of a manifest with public access:

{
    "name": "My Public Package #1",
    "version": "1.0.0",
    "allowPublicAccess": true,
    "extensions": [{
        "alias": "My.Whatever",
            "name": "My Whatever"
        }
    ]
}

Testing this PR

  1. The "all package manifests" endpoint should be available for users without access to packages, settings or the like. That is, a "simple" content editor with only content access should still be able to load the manifests.
  2. The new "public manifests" endpoint should be available without authentication.

Copy link
Contributor

@iOvergaard iOvergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kjac kjac merged commit e750d29 into v14/dev Mar 21, 2024
15 checks passed
@kjac kjac deleted the v14/fix/package-manifest-access branch March 21, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants