V13: Align database schemas of migrated and new database #15934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergmania
approved these changes
Apr 2, 2024
Zeegaan
pushed a commit
that referenced
this pull request
Apr 8, 2024
* Drop default constraint umbracoCacheInstruction table * Align umbracoContentVersion table * Update indexes on external login table * Align node table * Make relation type index unique * Remove user-group default constraint * Re-order methods * Make webhook url not nullable * Cleanup * Cleanup
Zeegaan
added a commit
that referenced
this pull request
Apr 9, 2024
* Added UserData and migrated tours data into it * Remove tourdata from user * Removed tour definition/manipulation classes Fixed a userData error typo * Removed toursettings * Update openapi spec * V13: Align database schemas of migrated and new database (#15934) * Drop default constraint umbracoCacheInstruction table * Align umbracoContentVersion table * Update indexes on external login table * Align node table * Make relation type index unique * Remove user-group default constraint * Re-order methods * Make webhook url not nullable * Cleanup * Cleanup * Update OpenApi.json * Update src/Umbraco.Cms.Api.Management/Controllers/UserData/UserDataControllerBase.cs * Remove tour settings from schema * Add cancelation tokens * Dont inject, but take as parameter * Remove some from injection * Update schema --------- Co-authored-by: Sven Geusens <sge@umbraco.dk> Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> Co-authored-by: Nikolaj Geisle <70372949+Zeegaan@users.noreply.github.com> Co-authored-by: Zeegaan <skrivdetud@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a migration that aligns the schemas of migrated V7 and brand-new V13 databases.
To compare I've used the schema compare tool in VS, with column order disabled, after the migration the schemas align.
Testing
To test this I've migrated a v7 database, with a piece of simple content up to v13/dev and run the migration, after this I've verified that the content still works and that the schemas are now aligned.
Additionally I've tested that on a fresh V13 data base no SQL queries are executed.