Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V14 QA Fixed/Cleaned up the api acceptance tests #15964

Merged
merged 14 commits into from Apr 3, 2024

Conversation

nhudinh0309
Copy link
Contributor

No description provided.

Copy link
Contributor

@andr317c andr317c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had two comments

@@ -1,55 +0,0 @@
import {test} from '@umbraco/playwright-testhelpers';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this deleted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, there are no endpoints for create/update/delete Relation Type, so I deleted this file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should uncomment the file instead of deleting it. 🤔

nhudinh0309 and others added 2 commits April 3, 2024 15:34
…/Dictionary.spec.ts

Co-authored-by: Andreas Zerbst <73799582+andr317c@users.noreply.github.com>
Copy link
Contributor

@andr317c andr317c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andr317c andr317c merged commit be58f31 into v14/dev Apr 3, 2024
15 of 16 checks passed
@andr317c andr317c deleted the v14/QA/fix-api-acceptance-tests branch April 3, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants