Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V14: Fix entity type container repository get #15974

Merged

Conversation

Zeegaan
Copy link
Member

@Zeegaan Zeegaan commented Apr 3, 2024

Notes

  • Fixed a bug, where the data-type/folde/{id}, would throw errors, if you provided a non-folder entity key. (For example, using a data-type key, not a data-type-folder key)

How to test

  • Go to settings, and click one of you datatypes, copy the key of the datatype.
  • Call thedata-type/folde/{id} endpoint with the data type key, this should now return a 404, not a 500

Copy link
Contributor

@nikolajlauridsen nikolajlauridsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tests good.

Also ensure that /data-type/{id} also returns 404 when given a folder key 👍

@nikolajlauridsen nikolajlauridsen merged commit b5c6a20 into v14/dev Apr 4, 2024
16 checks passed
@nikolajlauridsen nikolajlauridsen deleted the v14/bugfix/fix-entity-type-container-repository-get branch April 4, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants