Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

v14: Remove UI settings from BackOfficeExternalLoginProviderOptions #16064

Conversation

Zeegaan
Copy link
Member

@Zeegaan Zeegaan commented Apr 16, 2024

Notes

  • Removed all UI elements of BackOfficeExternalLoginProviderOptions
  • Unsure if removing CustomBackOfficeView is necessary, as I think that is determined by the client now, but not entirely sure 馃

Breaking changes

Removed the following properties from BackOfficeExternalLoginProviderOptions:

  • ButtonStyle

  • ButtonLook

  • ButtonColor

  • Icon

  • AutoRedirectLoginToExternalProvider

  • CustomBackOfficeView

  • Removed the GetAutoLoginProvider method from IBackOfficeExternalLoginProviders

  • Removed the UuiButtonColor.cs & UuiButtonLook.cs classes

@Zeegaan Zeegaan changed the title Remove UI settings v14: Remove UI settings from BackOfficeExternalLoginProviderOptions Apr 16, 2024
@iOvergaard
Copy link
Contributor

Unsure if removing CustomBackOfficeView is necessary, as I think that is determined by the client now, but not entirely sure 馃

Yup, this should be removed from the options 馃憤

Copy link
Member

@bergmania bergmania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good, but please write in the description exactly what is breaking

@Zeegaan Zeegaan merged commit 4118f44 into v14/dev Apr 22, 2024
17 checks passed
@Zeegaan Zeegaan deleted the v14/feature/remove-ui-settings-from-external-login-provider-options branch April 22, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants