Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V13: Fix routing with string parameter #16344

Merged
merged 1 commit into from
May 22, 2024

Conversation

nikolajlauridsen
Copy link
Contributor

Fixes routing when a string parameter is used

This was caused by #16218 not considering invalid candidates

Fixes #16332 and #16341

Teting:

Create a site with a URL with more than one segment I.E

  • Root
    • Child
      • Grandchild

Add an attribute routed endpoint with a string I.E.:

[HttpGet("sitemap-{group}-xml")]
    public IActionResult AttributeRoute(string group)
    {
        _logger.LogInformation("Got request: {GroupValue}", group);
        return Ok();
    }

Ensure you can request both /child/grandchild and /sitemap-something-xml

@bergmania bergmania merged commit eb6bb99 into v13/dev May 22, 2024
13 of 16 checks passed
@bergmania bergmania deleted the v13/fix/consider-invalid-candidates branch May 22, 2024 11:29
bergmania pushed a commit that referenced this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom routes breaking on 13.3.1 update 13.3.1 Security Patch Contains Breaking Changes
2 participants