Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8: Fix YSODs when moving and copying things in the Settings section #3761

Merged
merged 1 commit into from Nov 28, 2018

Conversation

kjac
Copy link
Contributor

@kjac kjac commented Nov 26, 2018

Prerequisites

  • I have added steps to test this contribution in the description below

Description

TL;DR the enum MoveOperationStatusType must be of type byte, otherwise most move and copy operations appear to fail miserably in the UI.

When moving and copying things around in the Settings section, you're usually given this response:

image

The exception message is:

System.InvalidOperationException: Enum Umbraco.Core.Services.MoveOperationStatusType underlying type is not <byte>.

The move/copy operation actually succeeds, but the success message just doesn't work 😐 because MoveOperationStatusType is not of type byte:

image

@zpqrtbnk
Copy link
Contributor

OperationResultType does indeed specify in comments

// all "ResultType" enums must be byte-based, and declare Failed = 128, and declare
// every failure codes as >128 - see OperationResult and OperationResultType for details.

so MoveOperationStatusType should be named MoveOperationResultType and be byte-based.

merging - thanks!

@zpqrtbnk zpqrtbnk merged commit ec3fd89 into umbraco:temp8 Nov 28, 2018
@kjac kjac deleted the v8-fix-move-copy-status-type-ysod branch November 28, 2018 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants