Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8: Make Permission angular component more generic #5077

Closed
mattbrailsford opened this issue Mar 26, 2019 · 3 comments · Fixed by #5096
Closed

v8: Make Permission angular component more generic #5077

mattbrailsford opened this issue Mar 26, 2019 · 3 comments · Fixed by #5096

Comments

@mattbrailsford
Copy link
Contributor

mattbrailsford commented Mar 26, 2019

In the user groups editor, there is a list of toggle switches for toggling on and off permissions. In the angular js code, this has been coded as a Permission component for this exact purpose. Given it's just a list of toggle switches with text next to them, I think this should be made more generic so that it can be reused elswhere.

Case in point, if you look in the languages editor view, this also has a list of toggle switches and this has reused the permissions css classes which in this context makes this harder to understand as the list has nothing to do with permissions.

@Shazwazza
Copy link
Contributor

makes sense, I've marked this as "Up for grabs" so that you or someone else coming along could create a pull request for it.

@kjac
Copy link
Contributor

kjac commented Mar 27, 2019

Super great idea! I'll throw something together 👍

@kjac kjac mentioned this issue Mar 27, 2019
1 task
@kjac
Copy link
Contributor

kjac commented Mar 27, 2019

PR in #5096

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants