V8: Use umb-checkbox for RTE configuration #5119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @kjac Thanks for this contribution - as always, you'll hear from us if we need you, Em |
# Conflicts: # src/Umbraco.Web.UI.Client/src/views/propertyeditors/rte/rte.prevalues.controller.js # src/Umbraco.Web.UI.Client/src/views/propertyeditors/rte/rte.prevalues.html
ghost
assigned 
|
@kjac Looks great! I've merged in the latest v8 to resolve the merge conflicts. One little problem: it seems I can not (de)select any stylesheets, saving with a checked on stylesheet just returns an non-checked list on refresh. Maybe it has something to do with the recent changes to enable folders for stylesheets? |
|
There's bound to be conflicts there. Serves me right for doing so many PR's 馃槅 I'll have a look at it 馃憤 |
|
@nul800sebastiaan it's fixed now 馃憤 |
|
YAS! Awesome, works great now, lovely update, cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This PR replaces the existing system checkboxes with
umb-checkboxon the RTE configuration:Whoo, pretty 馃帀
Note: This PR conflicts with the logic implemented in #5068 to support stylesheets in nested folders. Both PRs are authored by me though, so once either one is merged I'll update the other.