V8: Fix node permissions YSOD (mapping issue) #5176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zpqrtbnk
reviewed
Apr 6, 2019
| @@ -167,6 +167,7 @@ private void Map(IUserGroup source, UserGroupBasic target, MapperContext context | |||
| // Umbraco.Code.MapAll -Udi -Trashed -AdditionalData -Id -AssignedPermissions | |||
There was a problem hiding this comment.
Note the -Id here: the // Umbraco.Code.MapAll comment triggers a Roslyn Analyzer (that is included via NuGet) that verifies that all target fields are assigned a value - except those that are excluded with a -Value comment. So... Id was excluded, quite probably because AutoMapper did exclude it too. How did it get mapped, then? No idea.
Going to merge the PR - and then to remove the -Id in the comment, if we do want it to be mapped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixes #5171
Description
See #5171 for details on the issue and how to replicate it. It's a side effect of #5087 - the UserGroup ID must be included when mapping UserGroup to AssignedUserGroupPermissions, otherwise things break 😄
Testing this PR
Testing this PR is simple... if you can open the permissions dialog for an item in the content tree, the fix works 😆