v8: Make TypeCollectionBuilderBase chainable

[mattbrailsford]

When composing collections, most of the CollectionBuilderBase classes are chainable such that you can chain add / remove commands in a fluent manor. For some reason though this doesn't appear to be possible with the TypeCollectionBuilderBase. I think this should be made consistent with the other base classes and allow a similar API.

[zpqrtbnk]

would totally make sense indeed. Would it be a breaking change? Guess yes... 8.1 then?

[mattbrailsford]

I don't think so as all Add / Remove methods are currently return void so those can continue to function as before, then just now return a instance of the collection to allow chaining.

[mattbrailsford]

ie, yes the signature is changing, but because they didn't return anything before, I think it's ok to now make them return something.

[zpqrtbnk]

fancy a PR? :-)

[mattbrailsford]

@zpqrtbnk would love to if I wasn't spending all my time v8-ifying TC 😁

[zpqrtbnk]

PR #5354

[Shazwazza]

Have merged, it's marked as breaking (since the generic signature changes) but expect this will affect a very very tiny amount of people