Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8: Fix the back button for media type list views #5602

Merged
merged 1 commit into from
Jun 23, 2019

Conversation

kjac
Copy link
Contributor

@kjac kjac commented Jun 6, 2019

Prerequisites

  • I have added steps to test this contribution in the description below

Description

If you have a media type with list view enabled, the server throws an error when you browse upwards through the tree (using the back button):

media-list-view-back-before

It happens because the backoffice attempts to load the parent node using an ID with a query string appended. This PR simply strips the query string part of the ID so the server can figure out which GetById method to use.

When this PR is applied, things start working:

media-list-view-back-after

@emmaburstow
Copy link
Contributor

Hey Kenn,

Thanks for the contributions - I'm about to copy paste some thanks here as there are a few so please forgive me 😂

Em

@nul800sebastiaan nul800sebastiaan merged commit acf63fc into umbraco:v8/dev Jun 23, 2019
@nul800sebastiaan
Copy link
Member

Sweet, thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants