use modifiable media path in file system composition

[ceee]

Problem

It was not possible to change the media path without using a custom composer like this:

public class CoreComposer : IUserComposer
{
  public void Compose(Composition composition)
  {
    composition.SetMediaFileSystem(() => new PhysicalFileSystem(SystemDirectories.Media));
  }
}

That's because the FileSystems composer uses a hard-coded folder ~/media for the PhysicalFileSystem and ignores the SystemDirectories.Media path which can be changed via the appSettings configuration.

composition.SetMediaFileSystem(() => new PhysicalFileSystem("~/media"));

Description

It's basically a one liner which replaces the mentioned hard-coded string with:

composition.SetMediaFileSystem(() => new PhysicalFileSystem(SystemDirectories.Media));

[nul800sebastiaan]

Ah good one @ceee - that should never have been hardcoded in the first place! 👍

Oh and woohoo! Congrats on your first accepted contribution to Umbraco CMS! 🎉

You've earned yourself that shiny new Contributor badge on Our Umbraco https://our.umbraco.com/members/id:113054/ 🎖

[nul800sebastiaan]

Cherry picked for 8.1.3 600be98