Disable Mini Profiler

[elit0451]

Mini Profiler will be disabled when a solution is not in a debug mode, therefore Mini Profiler Startup Profiler won't be accessible.

Fixes: AB#2178

[Shazwazza]

@elit0451 great work!

@nul800sebastiaan I have merged and cherry picked to dev/7.15 branch ready to go for the next 7.15.3 patch.

[ronaldbarendse]

This looks like a really ugly hack, as it removes ASP.NET MVC routes based on URL... Why not make sure the MiniProfiler doesn't add the routes to begin with (https://stackoverflow.com/questions/37681166/is-it-possible-to-disable-mini-profiler-handler)?

[ronaldbarendse]

Or at least remove the routes based on the name: #5206 (comment)

[Shazwazza]

@ronaldbarendse because the old mini profiler isn't that flexible. The code that creates the routes in the old profiler adds the routes on a static constructor so as soon as that class is referenced for any reason the routes are created. So yes it's a hack, but it's the only way to prevent this.

In 8 we don't need to do this and the new mini profiler is done in a nicer way without running logic on a static ctor.

[ronaldbarendse]

I see, but removing the route based on the name would be better then on some configured URL prefix (that could therefore match more than the MiniProfiler route).

The route name is based on the prefix, so it's a quick rewrite: https://github.com/MiniProfiler/dotnet/blob/04f8ac465349a85a77d9fa4c6528fb75e63e157c/src/MiniProfiler/MiniProfilerHandler.cs#L59-L63.

[Shazwazza]

Sure, if you have time to send a PR that would be superb

[Shazwazza]

One thing to note is that code is referencing the newer version of MiniProfiler, you'll have to check back in history to when this was done in the static ctor and check what the route name might be there. It might not have changed but would need to be sure.

[ronaldbarendse]

Just checked the decompiled code from MiniProfiler 2.1.0 (as the source isn't on GitHub) and the route is added the same way, but as it uses Insert, it's not using a named route 😬

The current fix is still too greedy, as it could still find the route based on the exact URL (instead of 'starts with'). The route URL is constructed as follows:

string prefix = MiniProfiler.Settings.RouteBasePath.Replace("~/", string.Empty).EnsureTrailingSlash();
string routeUrl = prefix + "{filename}";

The EnsureTrailingSlash() extension method should probably be changed to use the Umbraco built-in EnsureEndsWith(), but otherwise it's a quite simple change (I currently don't have the time the create a PR for it though).