Data type usage reporting and deletion warning #6625

Shazwazza · 2019-10-09T03:06:08Z

Displays a report when viewing a data type to show where it is used: Document types, media types, member types and optionally for which property editors. This feature also adds a new deletion prompt when deleting a data type to let you know exactly where it is used before you agree to delete it.

Changes

data type ui updated to support content app layout - this means moving some stuff around since each view is now responsible for the parts of the data type layout
data type angular updated to use more modern apis (controller as, etc...)
report data is only requested when the releations tab is active
new IDataTypeService.GetReferences
new DataTypeController.GetReferences endpoint for angular
Fixes navigating in angular when navigating via an html local url (there was a bug in this)
updated delete dialog/controller to show where the data type is used, this now uses more modern apis (controller as, etc...)

Testing

Ensure unit tests all pass
Review code
Ensure data type creation & editing all works as expected
Ensure the relations report is working and is accurate when clicking the relations tab
Ensure you can click through to the related content type items
Ensure the relations delete report is working and is accurate when trying to delete a data type and make sure you can still delete the data type

…pdate-datatype-edit-view

…ataTypeTracking

…e-edit-view' into v8/feature/AB2913-DataTypeTracking

…d wires that up to angular

… reloaded the view.

… change when using null for separator

bergmania · 2019-10-11T11:35:14Z

@nielslyngsoe
I couldn't find the unit tests of the umbCmsJoinArray filter? You probably forgot to add the file to the commit

I added some tests myself and think some of the behavior was a bit funny.
If I used null as seperator, then the output uses 'null' as sperator. I expected ''. So I changed this

Hopefully you can figure out how to merge my tests with the one you forgot to push.
You can see my tests here: https://github.com/umbraco/Umbraco-CMS/blob/261dc2af9881b8bba754368d0cd335e9e81ad311/src/Umbraco.Web.UI.Client/test/unit/common/filters/umbCmsJoinArray.filter.spec.js

bergmania

Added some small comments

src/Umbraco.Web.UI.Client/src/less/components/umb-table.less

src/Umbraco.Web/Models/ContentEditing/DataTypeReferences.cs

bergmania · 2019-10-11T12:13:57Z

Seems to work as expected :)

Do you agree on my change to the filter, and comments?

…ataTypeTracking # Conflicts: # src/Umbraco.Web.UI/Umbraco/config/lang/en.xml

nielslyngsoe and others added 24 commits October 2, 2019 10:28

first step for changing the datatype edit view

69d97bc

added fake test for this prototype

ab1f9f3

added a view for datatype relations

3ff2996

Merge remote-tracking branch 'origin/v8/dev' into v8/feature/AB2918-u…

cca66be

…pdate-datatype-edit-view

added more translations

65c4989

correctied area key for translation

3365d6f

whitespace

79d20bf

tabName translation

dbee0da

changed look and translation keys

8e17245

corrected working

097ef82

changed to headlines to h5

3da6465

Implements DataTypeService.FindUsages

bcc76b2

changed wording

69fb12a

corrected open links

eff284c

seperate row for icons

dfc642e

auto width for actions

5deaf99

Merge remote-tracking branch 'origin/v8/dev' into v8/feature/AB2913-D…

982a7c6

…ataTypeTracking

Merge remote-tracking branch 'origin/v8/feature/AB2918-update-datatyp…

b53eae0

…e-edit-view' into v8/feature/AB2913-DataTypeTracking

dont know why this was removed, brain fart...

ab6f4af

removing console.logs

a178a4d

Merge remote-tracking branch 'origin/v8/feature/AB2918-update-datatyp…

0e34c5e

…e-edit-view' into v8/feature/AB2913-DataTypeTracking

Adds new endpoint to DataTypeController to return the correct data an…

ac30017

…d wires that up to angular

ensure the data type refs are only loaded when the tab is activated

4c131d1

Fixes navigating to other items via url

cf9add7

Shazwazza added release/8.3.0 type/feature labels Oct 9, 2019

fixes build

4c344fc

Shazwazza marked this pull request as ready for review October 9, 2019 05:08

Shazwazza changed the title ~~DataType tracking~~ DataType tracking with report Oct 9, 2019

Shazwazza changed the title ~~DataType tracking with report~~ Data type usage reporting Oct 9, 2019

leekelleher mentioned this pull request Oct 9, 2019

Data type usage stats #6161

Closed

nielslyngsoe added 12 commits October 9, 2019 12:54

added no overflow for properties

fd7b85f

set template to cache output since its not going to update unless you…

7024bc4

… reloaded the view.

ups, misspelling of localization key

2d693dd

adding new localizations

18e8cae

Delete dialog for datatype that has relations

dda9927

rename to Reference

0429711

rename relations to references, to avoid misunderstanding.

f658c15

highlight properties begin deleted + corrected array

e7363ad

changed wording

e7faa14

simplified wording by removing "based on it"

5035438

listing out properties with exclamation mark icon in front of each

188cc2a

align icons if the are in a umb-table

c091d21

Shazwazza changed the title ~~Data type usage reporting~~ Data type usage reporting and deletion warning Oct 10, 2019

Changes filter name

b400a72

bjarnef mentioned this pull request Oct 11, 2019

Data types/doc types “Health Check” - Clean up Dashboard #4925

Closed

AB2913 - Added unit tests for the umbCmsJoinArray filter, and a small…

261dc2a

… change when using null for separator

bergmania reviewed Oct 11, 2019

View reviewed changes

src/Umbraco.Web.UI.Client/src/less/components/umb-table.less Outdated Show resolved Hide resolved

src/Umbraco.Web/Models/ContentEditing/DataTypeReferences.cs Outdated Show resolved Hide resolved

nielslyngsoe and others added 4 commits October 21, 2019 08:49

no need for this comment anymore

f2381da

removed comment

c89ea71

fix name to follow the class name

ba215f8

Merge remote-tracking branch 'origin/v8/dev' into v8/feature/AB2913-D…

c072015

…ataTypeTracking # Conflicts: # src/Umbraco.Web.UI/Umbraco/config/lang/en.xml

bergmania merged commit ed6fee4 into v8/dev Oct 21, 2019

bergmania deleted the v8/feature/AB2913-DataTypeTracking branch October 21, 2019 08:10

clausjensen added release/8.4.0 and removed release/8.3.0 labels Nov 4, 2019

nul800sebastiaan mentioned this pull request Nov 5, 2019

Solutions for removal of Change Document Type #7044

Closed

umbrabot added the type/feature label Oct 22, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Data type usage reporting and deletion warning #6625

Data type usage reporting and deletion warning #6625

Shazwazza commented Oct 9, 2019 •

edited

bergmania commented Oct 11, 2019 •

edited

bergmania left a comment

bergmania commented Oct 11, 2019

Data type usage reporting and deletion warning #6625

Data type usage reporting and deletion warning #6625

Conversation

Shazwazza commented Oct 9, 2019 • edited

Changes

Testing

bergmania commented Oct 11, 2019 • edited

bergmania left a comment

Choose a reason for hiding this comment

bergmania commented Oct 11, 2019

Shazwazza commented Oct 9, 2019 •

edited

bergmania commented Oct 11, 2019 •

edited