Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8.2 RTE image dialog doesn't display title #6712

Closed
skartknet opened this issue Oct 15, 2019 · 6 comments · Fixed by #6722
Closed

V8.2 RTE image dialog doesn't display title #6712

skartknet opened this issue Oct 15, 2019 · 6 comments · Fixed by #6722

Comments

@skartknet
Copy link
Contributor

The image dialog in the RTE misses some styling and the title. It feels like it's not a finished dialog.

image

image

Bug summary

  • Modal dialog misses Title
  • Not sure if it also misses some styling, like some padding below the title box.
  • Missing some labels?

Steps to reproduce

I have inserted an image in the RTE using the drag and drop functionality. Then I select the image in the RTE and click in the Media Picker button and a dialog opens on the right which is a bit confusing as it doesn't says what it's for and misses some styling I think:

Expected result

A more clear meaning of what that dialog is for.

Actual result

Confusing, the first time it opened I didn't know what that was for.

@kjac
Copy link
Contributor

kjac commented Oct 16, 2019

Yeah... I saw this one too yesterday. It's on my to-do list.

@nul800sebastiaan
Copy link
Member

Funnily enough, this is what that dialog looks like in 8.1.5

image

I'm not sure we should not even be showing that URL.. there's nothing you can do with it? Or at least then it should be a clickable link or something.

But you've never been able to update the name of the file from this dialog, what would the use case for that be?

@kjac
Copy link
Contributor

kjac commented Oct 16, 2019

I think the whole thing needs a bit of a makeover. There are several issues with it, specially when editing existing images from the rte. I'll be having a look later.

@skartknet
Copy link
Contributor Author

I'd say it should probably display the picker to replace the image.

@kjac
Copy link
Contributor

kjac commented Oct 16, 2019

Yeah so this was a can of worms... PR in #6722

@nul800sebastiaan
Copy link
Member

Fixed in #6722

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants