Forms dashboard: Add translations and hide icon for screen readers #6883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poornimanayar
approved these changes
Oct 29, 2019
|
Updated PR with |
|
Merged. Thanks @BatJan ⭐️ |
kjac
added
category/accessibility
community/pr
hacktoberfest/contrib-2019
release/8.6.0
type/feature
release/no-notes
nul800sebastiaan
removed
the
release/no-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
I have created translation keys for those that were missing and mapped the translations in the view. I have also added the
aria-hidden="true"attribute on the icon so screen readers will not try to announce them.