Spelling mistake on word Success in instructional comment. #6966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjac
requested changes
Dec 20, 2019
There was a problem hiding this comment.
Hi @kieronbos - thank you for this 😄
I think you have updated something that was deprecated to begin with. I for one can't see any reference to RedirectOnSuccess anywhere in the source (except in the view you just updated).
In fact I believe the comment should refer to profileModel.RedirectUrl and the snippet docs updated accordingly - see https://github.com/umbraco/Umbraco-CMS/blob/v8/dev/src/Umbraco.Web.UI/Umbraco/PartialViewMacros/Templates/RegisterMember.cshtml for inspiration.
kjac
approved these changes
Jan 16, 2020
|
I've updated the PR according to the review above. |
|
Merged. Thanks again, @kieronbos |
kjac
added
community/pr
hacktoberfest/contrib-2019
release/8.6.0
release/no-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simple spelling mistake on Partial view snippet instructional comment.