Move the infinite overlay to the same source order as regular overlays #7923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
I have just decided to close #4526 without having it merged in it's current state since the stuff I made no longer works.
Therefore I decided to have a deeper look at some of the root causes to some of the issues I faced when trying to implement the focus lock. One of them being that regular overlays and infinite overlays got triggered from different places within the source code meaning I had to do so weird little hacks to get it working. Move the infinite overlay out of the source order it will be a lot simpler to implement a well working focus lock - So this is what I have done with this PR 😃
The
<umb-editors>component has been moved to the same level in the source code as the<umb-overlay>component, since it's an overlay too really. I have also removed the<div class="umb-editor__overlay" ng-if="infiniteMode"></div>and added<umb-backdrop ng-if="backdrop.show || infiniteMode">...<div>to make the backdrop behave much more aligned with what you would expect from an overlay meaning that you now can't click on the content tree using your mosue - Just like with regular overlays making the overall experience much more consistent and improves the UX.When this PR is hopefully accepted I will start looking at adding the focus lock again since this change will make it a lot easier to achieve 😄
Visually this is what it acts like before and after
Before
After
