New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Acceptance tests for Content #8622
Merged
bergmania
merged 11 commits into
v8/dev
from
v8/feature/AB7482-acceptance-tests-for-content
Sep 9, 2020
Merged
Acceptance tests for Content #8622
bergmania
merged 11 commits into
v8/dev
from
v8/feature/AB7482-acceptance-tests-for-content
Sep 9, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cceptance-tests-for-content # Conflicts: # src/Umbraco.Tests.AcceptanceTest/package.json
bergmania
requested changes
Aug 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good, but we do way to much in the UI. This is an anti-pattern. There exists builders for content and a SaveContent
in the testhelper project
src/Umbraco.Tests.AcceptanceTest/cypress/integration/Content/content.ts
Outdated
Show resolved
Hide resolved
src/Umbraco.Tests.AcceptanceTest/cypress/integration/Content/content.ts
Outdated
Show resolved
Hide resolved
src/Umbraco.Tests.AcceptanceTest/cypress/integration/Content/content.ts
Outdated
Show resolved
Hide resolved
src/Umbraco.Tests.AcceptanceTest/cypress/integration/Content/content.ts
Outdated
Show resolved
Hide resolved
src/Umbraco.Tests.AcceptanceTest/cypress/integration/Content/content.ts
Outdated
Show resolved
Hide resolved
…cceptance-tests-for-content
…cceptance-tests-for-content
…cceptance-tests-for-content # Conflicts: # src/SolutionInfo.cs # src/Umbraco.Web.UI.Client/src/views/propertyeditors/nestedcontent/nestedcontent.controller.js
I had some troubles with the sort test.. I figured out an easier way to implement it :) |
…cceptance-tests-for-content # Conflicts: # src/Umbraco.Web.UI.Client/src/views/propertyeditors/nestedcontent/nestedcontent.controller.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains acceptance tests for:
And also updates to (future) latest version of umbraco-cypress-testhelpers