Do not show cryptic confirm dialog when editing group #9048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanwoulfe
approved these changes
Nov 16, 2020
nul800sebastiaan
added
hacktoberfest/contrib-2020
and removed
hacktoberfest-accepted
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixes #9036
Description
Looks like #8739 was a tad too eager in showing confirmation dialogs. It resulted in somewhat cryptic dialogs when removing sections or granular permissions from a user group:
This PR ensures that we retain the confirmation dialog when removing users from groups, but avoid showing confirmation dialogs when removing sections or granular permissions: