Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RTE toolbar sticky #9316

Merged
merged 1 commit into from Oct 30, 2020
Merged

Conversation

mattbrailsford
Copy link
Contributor

@mattbrailsford mattbrailsford commented Oct 30, 2020

Prerequisites

  • I have added steps to test this contribution in the description below

Fixes #9315

Description

CSS update to the RTE toolbar to make it sticky. Now if the RTE area is larger than the viewport, as you scroll down the RTE toolbar will remain sticky to the content area meaning you don't have to scroll back up to access it.

To test, create an RTE in "classic" mode then enter a lot of content that forces it scroll beyond the view port height. When you scroll down, the RTE toolbar should now stick to the top of the viewport.

@emmaburstow
Copy link
Contributor

Hey Matt,

thanks for the PR. I love it :)

We'll take a look and let you know if we have questions.

Em

Copy link
Contributor

@emmaburstow emmaburstow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. Works as advertised

@umbrabot
Copy link

Hi there @mattbrailsford,

First of all: A big #H5YR for making an Umbraco related contribution during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🥇

Due to the amazing work you and others in the community have been doing, we've had a bit of a hard time keeping up. 😅 While all of the PRs for Hacktoberfest might not have been merged yet, you still qualify for receiving some Umbraco swag, congratulations! 🎉

In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you!

As a new choice this year, you can opt-out of receiving anything and ask us to improve the planet instead by planting a tree on your behalf. 🌳

Receive your swag or plant a tree! 👈 Please follow this link to fill out and submit the form, before February 26, 2021.

Following this date we'll be sending out all the swag, which also means that it might not reach your doorstep before April, so please bear with us and be patient 🙏

The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help!

Kind regards,
The various Umbraco Teams

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Umbraco V8 RTE - Make menu bar sticky
4 participants