Fix eventService memory leaks #9752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 4, 2021 00:05
…nto v8/bugfix/umbEditorHeader-memoryleak
nzdev
changed the title
|
tinymce.service.js also appears to be leaking via events, leaving tinymce content in memory, but services cant use $scope. |
nzdev
commented
Feb 3, 2021
src/Umbraco.Web.UI.Client/src/common/services/editor.service.js
Outdated
Show resolved
Hide resolved
nzdev
commented
Feb 3, 2021
nzdev
commented
Feb 3, 2021
...Web.UI.Client/src/common/directives/components/content/umbvariantcontenteditors.directive.js
Outdated
Show resolved
Hide resolved
nathanwoulfe
approved these changes
Feb 7, 2021
There was a problem hiding this comment.
Thanks @nzdev, I'd noticed memory spikes a while back when opening multiple infinite editors, this should help alleviate that issue. I've reverted the changes in the services as it's not required due to the lifespan of those object.
nul800sebastiaan
added
the
category/performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixes N/A
Description
What?
Fix memory leaks by unbinding event from $rootscope.
Why?
Memory leaks in the browser when events are not unbound from the $rootscope.
How to test?
Ensure memory freed when navigating the backoffice ui.