Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use umb-icon component in tree item #9759

Merged
merged 1 commit into from Feb 8, 2021
Merged

Use umb-icon component in tree item #9759

merged 1 commit into from Feb 8, 2021

Conversation

bjarnef
Copy link
Contributor

@bjarnef bjarnef commented Feb 3, 2021 •
edited

Prerequisites

  • I have added steps to test this contribution in the description below

Description

This PR replace the icon icon-check using <i> element with <umb-icon> in tree, where enablecheckboxes is used, e.g. in Move dialog.

GhM6FNaZ5c

nathanwoulfe
nathanwoulfe approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@nathanwoulfe nathanwoulfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks @bjarnef

@nathanwoulfe nathanwoulfe merged commit 044573d into umbraco:v8/contrib Feb 8, 2021
@bjarnef bjarnef deleted the v8/feature/umb-tree-icon branch February 8, 2021 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanwoulfe nathanwoulfe nathanwoulfe approved these changes

Assignees
No one assigned
Labels
category/ui User interface community/pr release/8.12.0 type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bjarnef @nathanwoulfe