Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: UmbVariantableWorkspaceContextInterface is marked as obsolete but suggested interface UmbVariantWorkspaceContextInterface does not exist #16689

Closed
KevinJump opened this issue Apr 18, 2024 · 4 comments · Fixed by umbraco/Umbraco.CMS.Backoffice#2138

Comments

@KevinJump
Copy link
Contributor

Describe the bug

UmbVariantableWorkspaceContextInterface is marked as obsolete in RC1

https://github.com/umbraco/Umbraco.CMS.Backoffice/blob/683187c28a0f923f320b075f35b88cd9cd07c2bd/src/packages/core/workspace/contexts/tokens/variant-dataset-workspace-context.interface.ts#L33-L37

The deprecation notice says to Use UmbVariantWorkspaceContextInterface instead, but this does not exist in the code base. ?

either:
the notice is wrong and there is another interface somewhere? or this interface is missing ?

@ksolberg
Copy link

ksolberg commented Jun 6, 2024

Any updates on this?

@ksolberg
Copy link

ksolberg commented Jun 6, 2024

Nevermind, consumed UMB_VARIANT_WORKSPACE_CONTEXT instead.

@iOvergaard iOvergaard transferred this issue from umbraco/Umbraco.CMS.Backoffice Jun 27, 2024
Copy link

Hi there @KevinJump!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@iOvergaard
Copy link
Contributor

The correct interface to replace it is called UmbVariantDatasetWorkspaceContext and that should already be exported. This is also the interface you get when consuming UMB_VARIANT_WORKSPACE_CONTEXT as @ksolberg points out. The deprecation notice is wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants