Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/document type editor correct tabs sorter #1315

Merged
merged 9 commits into from
Mar 4, 2024

Conversation

nielslyngsoe
Copy link
Member

Adding JSDocs
Removing unnesecary #model
Using disable/enable feature of Sorter
Rename resolveVerticalDirection to resolvePlacement — as that makes more sense.
Correcting the resolvePlacement(resolveVerticalDirection) function.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Copy link
Contributor

@loivsen loivsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, found a bug 😊

Copy link
Collaborator

@iOvergaard iOvergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems if I create a new group and go into sorter mode, I can sort the group just fine (although the "shadow" jumps down into its original position), however, I cannot leave sorter mode after that.

2024-03-04.at.17.10.10.-.Turquoise.Silverfish.mp4

Copy link
Collaborator

@iOvergaard iOvergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll fix the aforementioned issue later on. Merging this to allow for a better experience in the beta.

@iOvergaard iOvergaard disabled auto-merge March 4, 2024 20:56
@iOvergaard iOvergaard merged commit 3277145 into main Mar 4, 2024
6 checks passed
@iOvergaard iOvergaard deleted the bugfix/document-type-editor-correct-tabs-sorter branch March 4, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants