-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/document type editor correct tabs sorter #1315
Bugfix/document type editor correct tabs sorter #1315
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, found a bug 😊
...documents/document-types/workspace/views/design/document-type-workspace-view-edit.element.ts
Show resolved
Hide resolved
…editor-correct-tabs-sorter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems if I create a new group and go into sorter mode, I can sort the group just fine (although the "shadow" jumps down into its original position), however, I cannot leave sorter mode after that.
2024-03-04.at.17.10.10.-.Turquoise.Silverfish.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll fix the aforementioned issue later on. Merging this to allow for a better experience in the beta.
Adding JSDocs
Removing unnesecary #model
Using disable/enable feature of Sorter
Rename resolveVerticalDirection to resolvePlacement — as that makes more sense.
Correcting the resolvePlacement(resolveVerticalDirection) function.
Types of changes
Motivation and context
How to test?
Screenshots (if appropriate)
Checklist