Bugfix/modal selection fix #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tree pickers do not return any values since the extension initializer created an additional shadow root surrounding the default tree elements. This PR prevents any element extending
UmbExtensionElementAndApiSlotElementBasefrom creating a shadow root thus enabling events to propagate to anything outside listening in events, such as theUmbTreePickerModal, which needs to listen on "selected", "deselected", and "selection-change" events.Also fixes the stylesheet picker, which accidentally double-encoded the stylesheet path where it shouldn't.
Also fixes the data type create flow modal so it uses the correct parent context path.