Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor createExtensionApi for consistency #1364

Merged
merged 6 commits into from
Mar 5, 2024
Merged

refactor createExtensionApi for consistency #1364

merged 6 commits into from
Mar 5, 2024

Conversation

nielslyngsoe
Copy link
Member

@nielslyngsoe nielslyngsoe commented Mar 4, 2024 •
edited

Aligning createExtensionApi with other apporaches

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@nielslyngsoe nielslyngsoe marked this pull request as ready for review March 5, 2024 08:26
@nielslyngsoe nielslyngsoe merged commit 16189b9 into main Mar 5, 2024
6 checks passed
@nielslyngsoe nielslyngsoe deleted the feature/align-extension-initializers-args branch March 5, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsrasmussen madsrasmussen madsrasmussen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nielslyngsoe @madsrasmussen