Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement: modal token cleanup part 1 #1367

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Improvement: modal token cleanup part 1 #1367

merged 3 commits into from
Mar 5, 2024

Conversation

madsrasmussen
Copy link
Contributor

@madsrasmussen madsrasmussen commented Mar 5, 2024 •
edited

  • Move section input + token to section module
  • Move document picker to document module
  • Move template picker token to template module

@madsrasmussen madsrasmussen marked this pull request as ready for review March 5, 2024 08:50
@leekelleher leekelleher self-requested a review March 5, 2024 09:08
leekelleher
leekelleher approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. I'd noticed a separate issue with the Section Picker UI, but unrelated to this PR, (I've logged the issue I found elsewhere).

@leekelleher leekelleher merged commit 5540b43 into main Mar 5, 2024
7 checks passed
@leekelleher leekelleher deleted the improvement/modal-token-cleanup branch March 5, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leekelleher leekelleher leekelleher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@madsrasmussen @leekelleher