Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: (Templating section) Remove console warnings when closing modal #1369

Merged
merged 7 commits into from
Mar 5, 2024

Conversation

loivsen
Copy link
Contributor

@loivsen loivsen commented Mar 5, 2024

Description

Remove console warnings when closing a modal (templating section)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

@loivsen loivsen marked this pull request as ready for review March 5, 2024 09:53
@loivsen loivsen requested a review from iOvergaard March 5, 2024 09:53
loivsen and others added 4 commits March 5, 2024 12:24
…ting-item-menu.element.ts

Co-authored-by: Jacob Overgaard <752371+iOvergaard@users.noreply.github.com>
@loivsen loivsen requested a review from iOvergaard March 5, 2024 11:42
loivsen and others added 2 commits March 5, 2024 13:04
…-input/stylesheet-rule-input.element.ts

Co-authored-by: Jacob Overgaard <752371+iOvergaard@users.noreply.github.com>
…-input/stylesheet-rule-input.element.ts

Co-authored-by: Jacob Overgaard <752371+iOvergaard@users.noreply.github.com>
@iOvergaard iOvergaard merged commit c5dec2d into main Mar 5, 2024
6 checks passed
@iOvergaard iOvergaard deleted the bugfix/template-modal-console-warns branch March 5, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants