Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing media type picker #1383

Merged
merged 21 commits into from
Mar 6, 2024
Merged

Add missing media type picker #1383

merged 21 commits into from
Mar 6, 2024

Conversation

iOvergaard
Copy link
Collaborator

@iOvergaard iOvergaard commented Mar 5, 2024

What it says + now using it to configure the MediaPicker which should be able to choose media types and not use the Tree Picker.

Warning

I ended up messing about with the input values coming from the server. @kjac looked into it and said that all types are migrated to comma-separated strings, so I aligned the 4 different property editor UI's here, so we don't need to go back and forth with different value types.

Copy link

github-actions bot commented Mar 5, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-1383.westeurope.1.azurestaticapps.net

1 similar comment
Copy link

github-actions bot commented Mar 5, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-1383.westeurope.1.azurestaticapps.net

Copy link
Contributor

@loivsen loivsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there picked items from input-media-type doesn't render in the UI. Saves correctly though.
Maybe can add a catch => undefined to the modal as well while we at it 🥰

@iOvergaard iOvergaard disabled auto-merge March 5, 2024 18:15
@iOvergaard
Copy link
Collaborator Author

Looks like there picked items from input-media-type doesn't render in the UI. Saves correctly though. Maybe can add a catch => undefined to the modal as well while we at it 🥰

You are right. I don't think it's related to this, though. Those input types should "just work".

Copy link

github-actions bot commented Mar 5, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-1383.westeurope.1.azurestaticapps.net

1 similar comment
Copy link

github-actions bot commented Mar 5, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-1383.westeurope.1.azurestaticapps.net

Copy link

github-actions bot commented Mar 5, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-1383.westeurope.1.azurestaticapps.net

Copy link

github-actions bot commented Mar 5, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-1383.westeurope.1.azurestaticapps.net

@leekelleher

This comment was marked as outdated.

Copy link

github-actions bot commented Mar 6, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-1383.westeurope.1.azurestaticapps.net

Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it out, works as expected.

Spotted a small missing const import, (for MNTP's Member Type picker UI), which I've updated on here. All good.

Copy link

github-actions bot commented Mar 6, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-1383.westeurope.1.azurestaticapps.net

@leekelleher leekelleher merged commit 4ccf70b into main Mar 6, 2024
6 checks passed
@leekelleher leekelleher deleted the bugfix/media-picker-type branch March 6, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants