-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing media type picker #1383
Conversation
…t the server value could be a comma-separated string
Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-1383.westeurope.1.azurestaticapps.net |
1 similar comment
Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-1383.westeurope.1.azurestaticapps.net |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there picked items from input-media-type doesn't render in the UI. Saves correctly though.
Maybe can add a catch => undefined
to the modal as well while we at it 🥰
You are right. I don't think it's related to this, though. Those input types should "just work". |
…tch the migrated server data
…/Umbraco.CMS.Backoffice into bugfix/media-picker-type
Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-1383.westeurope.1.azurestaticapps.net |
1 similar comment
Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-1383.westeurope.1.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-1383.westeurope.1.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-1383.westeurope.1.azurestaticapps.net |
This comment was marked as outdated.
This comment was marked as outdated.
Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-1383.westeurope.1.azurestaticapps.net |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it out, works as expected.
Spotted a small missing const import, (for MNTP's Member Type picker UI), which I've updated on here. All good.
Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-1383.westeurope.1.azurestaticapps.net |
What it says + now using it to configure the MediaPicker which should be able to choose media types and not use the Tree Picker.
Warning
I ended up messing about with the input values coming from the server. @kjac looked into it and said that all types are migrated to comma-separated strings, so I aligned the 4 different property editor UI's here, so we don't need to go back and forth with different value types.