Feature/better-500-handling #1395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e this was written)
… so the notification doesn't fill up the entire screen - also add handling for a specific known cache corruption to let the user know to restart the server
kjac
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug where the Umbraco object cache becomes corrupted. The solution is to restart the server. We are investigating. While the investigation is ongoing, we would like to catch that error upfront and let the user know they should restart the server, so we have added a few keywords here to catch that.
While I was at it, I added more generic error handling specifically for 500 errors, so any developer can find the complete stack trace in the console while informing the user with a more human-readable message -- the old notification filled up the whole UI before.
To test, create a document type and repeatedly click Save until you start getting 500 errors. The message should inform you to restart your server. You should also see a group of error messages in the console.