Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Media Recycle Bin #1537

Merged
merged 9 commits into from
Apr 9, 2024
Merged

Feature: Media Recycle Bin #1537

merged 9 commits into from
Apr 9, 2024

Conversation

madsrasmussen
Copy link
Contributor

@madsrasmussen madsrasmussen commented Apr 4, 2024

Description

Implementation of the Media Recycle Bin. Builds on top of the Document Recycle Bin feature. Please see this PR for details: #1531

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

@madsrasmussen madsrasmussen marked this pull request as ready for review April 5, 2024 12:54
Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Same feedback/questions as #1531 (review).

I'm happy to approve this PR once we've clarified PR #1531. 👍

Base automatically changed from bugfix/document-recycle-bin to main April 9, 2024 19:00
@leekelleher leekelleher self-requested a review April 9, 2024 19:00
Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following clarifications on PR #1531, I'm happy with this PR too. 🚀

Copy link

github-actions bot commented Apr 9, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-1537.westeurope.1.azurestaticapps.net

@madsrasmussen madsrasmussen merged commit b3f7700 into main Apr 9, 2024
7 checks passed
@madsrasmussen madsrasmussen deleted the feature/media-recycle-bin branch April 9, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants