Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Picker inputs, updated to use UmbUniqueTreeItemModel #1574

Merged
merged 3 commits into from Apr 15, 2024

Conversation

leekelleher
Copy link
Member

Description

Straddling between chore and bugfix, I'd noticed that an issue in the MemberType picker where the MemberTypeItemResponseModel had bled through, whereas the UmbUniqueTreeItemModel could be used. Which also solved an issue I had with the Entity picker input component.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

@madsrasmussen
Copy link
Contributor

madsrasmussen commented Apr 11, 2024

In this case, I think the correct model is an UmbUniqueItemModel. It is the item endpoint we use to look up what has been picked. I don't know if we have this model, if we don't it would be good to add one.

I have for a long time thought about removing the "unique" part of the name. We have transitioned everything to work with a unique, so it might be good to get it on the base model instead. Any thoughts?

@leekelleher leekelleher marked this pull request as draft April 11, 2024 07:19
auto-merge was automatically disabled April 11, 2024 07:19

Pull request was converted to draft

@leekelleher
Copy link
Member Author

@madsrasmussen Thanks for the feedback, I've put this PR to draft and I'll investigate the UmbUniqueItemModel type (if it exists or not yet). 👍

@leekelleher leekelleher force-pushed the bugfix/pickers-unique-tree-item branch from be38bbd to 0240a2c Compare April 12, 2024 12:49
@leekelleher
Copy link
Member Author

leekelleher commented Apr 12, 2024

Okay, the UmbUniqueItemModel didn't exist, so I've added that for now. I agree that we could (should) drop the "Unique" part from the name, but UmbItemModel feels too opinionated (that an item must have a unique, name and icon), so started to think along the lines of UmbPickedItemModel, but I'm unsure. So let's go with UmbUniqueItemModel and refactor when we have a better name.

@leekelleher leekelleher marked this pull request as ready for review April 12, 2024 12:50
Copy link
Contributor

@madsrasmussen madsrasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@leekelleher leekelleher merged commit a0a25fd into main Apr 15, 2024
7 checks passed
@leekelleher leekelleher deleted the bugfix/pickers-unique-tree-item branch April 15, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants