Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extension-slot life cycle issue #1578

Merged
merged 5 commits into from
Apr 11, 2024

Conversation

nielslyngsoe
Copy link
Member

Extension-slots require an unknown set of properties to be set before it makes sense for them to start initialising extensions.
This life-cycle has been improved as of this PR. and fixes an issue on the user-workspace.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out in all of the places where I'd noticed the issue yesterday, and the errors have gone. Backoffice is working as currently expected. 👍

@nielslyngsoe nielslyngsoe merged commit 371bdc7 into main Apr 11, 2024
8 checks passed
@nielslyngsoe nielslyngsoe deleted the bugfix/extension-slot-life-cycle-issue branch April 11, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants