Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: unset extensionsController when destroyed #1597

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Fix: unset extensionsController when destroyed #1597

merged 3 commits into from
Apr 12, 2024

Conversation

nielslyngsoe
Copy link
Member

Fixing a JS error where extensionsController has been destroy but is still set as a property.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@leekelleher leekelleher self-requested a review April 12, 2024 12:09
@nielslyngsoe nielslyngsoe merged commit fe284f2 into main Apr 12, 2024
7 checks passed
@nielslyngsoe nielslyngsoe deleted the bugfix/extension-slot-unset-ext-initializer branch April 12, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leekelleher leekelleher leekelleher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nielslyngsoe @leekelleher