Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Hide entity actions when Tree used inside a Modal #1598

Merged
merged 2 commits into from Apr 15, 2024

Conversation

leekelleher
Copy link
Member

Description

@madsrasmussen @nielslyngsoe As discussed recently, a proposed PR.

Adds a flag to the umb-tree to hide the tree-item's entity actions. This can be useful when using a tree-picker modal and don't want to enable the user to access the entity actions.

As for whether the the larger feature of "why not?" allow content-managers to run actions within pickers, we can discuss and explore further.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Copy link
Contributor

@madsrasmussen madsrasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@leekelleher leekelleher merged commit a7cb98f into main Apr 15, 2024
6 of 7 checks passed
@leekelleher leekelleher deleted the feature/tree-picker-modal-hide-entity-actions branch April 15, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants