Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: delete tab in content-type design editor #1636

Merged
merged 1 commit into from Apr 16, 2024
Merged

Bugfix: delete tab in content-type design editor #1636

merged 1 commit into from Apr 16, 2024

Conversation

nielslyngsoe
Copy link
Member

@nielslyngsoe nielslyngsoe commented Apr 16, 2024 •
edited

Ah, I guess i was tired when i wrote this originally. here is a fix. :-)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@leekelleher leekelleher self-requested a review April 16, 2024 18:42
leekelleher
leekelleher approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out, it works as expected! 👍

@leekelleher leekelleher merged commit f2ab5fd into main Apr 16, 2024
8 checks passed
@leekelleher leekelleher deleted the bugfix/content-type-delete-tab branch April 16, 2024 18:44
@leekelleher leekelleher changed the title fix: delete tab in content-type design editor Bugfix: delete tab in content-type design editor Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leekelleher leekelleher leekelleher approved these changes

Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nielslyngsoe @leekelleher