Bugfix: Add correct Block Type label to Block Workspace editor #2017
+33
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickbutterfield
changed the title
| @@ -218,6 +229,11 @@ export class UmbBlockWorkspaceContext<LayoutDataType extends UmbBlockLayoutBaseM | |||
| throw new Error('Block Entries could not create block'); | |||
| } | |||
|
|
|||
| const blockType = this.#blockManager!.getBlockTypeOf(contentElementTypeId); | |||
| if (blockType?.label) { | |||
| this.setName(blockType.label); | |||
There was a problem hiding this comment.
We are still missing the Label interpretation feature, meaning using the Label (template) would not necessary be very pretty.
How was it in v.13, did we show the interpolated label in the header of the modal? :-)
There was a problem hiding this comment.
Ah, you're right! The modal label shows the interpolated version of it. 🤦♂️ Shall I draft this until that gets resolved?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Correctly loads the Block Type from the Block Manager, gets the
labelproperty and saves it within the Block Workspace context for loading in the create/edit modal.Types of changes
Motivation and context
Fixes umbraco/Umbraco-CMS#16463
How to test?
Try creating or editing any block within a Block List or Block Grid, and make sure the modal shows the correct Block Type name
Screenshots (if appropriate)
Before:
After:
On create
On edit
Checklist