Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement: Data Type Repository split #983

Merged
merged 30 commits into from Nov 14, 2023
Merged

Improvement: Data Type Repository split #983

merged 30 commits into from Nov 14, 2023

Conversation

madsrasmussen
Copy link
Contributor

@madsrasmussen madsrasmussen commented Nov 13, 2023 •
edited

Our Repositories are growing in size and we need to split them into multiple repositories based on responsibility.

Merges together with: umbraco/Umbraco-CMS#15199

@madsrasmussen
add entity item store
dd035d3
@madsrasmussen
split item into its own module
f6271c5
@madsrasmussen
split out move and copy
0ac2f99
@madsrasmussen
move data sources next to repo
fa52a15
@madsrasmussen
align file names
d5b8177
@madsrasmussen
split folder from repo
5a0afcd
@madsrasmussen
register repositories
8269eed
@madsrasmussen
use correct repo in entity action
5f6dd69
@madsrasmussen
move tree store
ac9655a
@madsrasmussen
move tree store manifest to tree module
44a80b0
@madsrasmussen
split into tree repository
1cd3644
@madsrasmussen
wip: collect data type detail repo in one folder
92d05cd
@madsrasmussen
rename data source
b18710f
@madsrasmussen
Update data-type-detail.repository.ts
5d5bd9d
@madsrasmussen
move data type store
9ca491c
@madsrasmussen
add detail to store name
37ed4bd
@madsrasmussen
update imports
b1cef5d
@madsrasmussen
fix manifests
1a15ae4
@madsrasmussen
remove duplicates
cac3ed5
@madsrasmussen
align method calls
f58bff2
@madsrasmussen
import correct repository alias
2736833
@madsrasmussen
fix wrong repositories
a586e2b
@madsrasmussen
remove token from name
a754b8f
@madsrasmussen
move data type files from settings into core
f11f671
@madsrasmussen
update import maps
9de4baf
@madsrasmussen
use correct repository
3e093d7
@madsrasmussen
export all repositories
6c1ca9d
@madsrasmussen
control module exports
e73afe1
@madsrasmussen madsrasmussen marked this pull request as ready for review November 13, 2023 20:04
loivsen
loivsen requested changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@loivsen loivsen left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The entity action delete uses requestItems which is from your new item repository, it currently seems that the action gets the detail repository.

Otherwise great updates 🥇

@madsrasmussen
Copy link
Contributor Author

The entity action delete uses requestItems which is from your new item repository, it currently seems that the action gets the detail repository.

Otherwise great updates 🥇

Good catch! I will get it fixed

@madsrasmussen madsrasmussen mentioned this pull request Nov 14, 2023
Merged
@madsrasmussen madsrasmussen merged commit 52e41be into main Nov 14, 2023
6 checks passed
@madsrasmussen madsrasmussen deleted the improvement-data-type-repo-split branch November 14, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loivsen loivsen loivsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@madsrasmussen @loivsen