Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend show form save success message after notification cancel operation #1002

Closed
soeren-eckel-adesso opened this issue Mar 31, 2023 · 1 comment
Labels
release/10.5.2 release/12.1.2 state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks type/bug

Comments

@soeren-eckel-adesso
Copy link

soeren-eckel-adesso commented Mar 31, 2023

A brief description of the issue goes here.

When adding a Form Saving Notifiacation Handler and cancel operation the form is not saved, but the backend ui shows a form saved message.

Reproduction

If you're filing a bug, please describe how to reproduce it. Include as much
relevant information as possible, such as:

Bug summary

Form save action dont't show proper notifiaction user message.

Specifics

Umbraco.Cms: 10.4.1
Umbraco.Forms: 103.0
Browser: Edge

Steps to reproduce

  • Create a form
  • add add Form Saving Notifcation Handler
public class FormSavingNotificationHandler : INotificationHandler<FormSavingNotification>
{
    public void Handle(FormSavingNotification notification)
    {
        notification.CancelOperation(new EventMessage("Error", "Test Error"));
    }
}
  • save form

Expected result

Form shows error message to user

Actual result

Form shows success message
image


This item has been added to our backlog AB#33490

@AndyButland AndyButland added the state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks label Oct 7, 2023
@AndyButland
Copy link

We'll fix this up so you get a red error bar in this case, with your message included. Will be part of the next round of patch releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/10.5.2 release/12.1.2 state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks type/bug
Projects
None yet
Development

No branches or pull requests

2 participants