-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Starter kits: dotnet new templates not umbraco packages? #53
Comments
Hey @LottePitcher 👋 First impression - I don't hate it, and tend to agree that a template makes more sense than a package as a starter kit is the baseline for a new project, not something added to supplement/extend an existing project. There would obvs be some changes required to make it work, but ultimately we're still talking about nuget packages, just a different flavour. Ideally I think we'd be considering template-type packages and treating these as we do 'normal' packages, so that we can display both types in the existing categories (we'd likely then have packages, integrations and templates) Andy is off this week, but we'll discuss when he's back and will update here. |
Hi Lotte, |
Thank you @nathanwoulfe and @BoletteKern for your thoughts. I'll be sure to post a link here to any starter kit(s) released as templates so there are real examples to consider. :-) |
Everyone that created a local Umbraco project will have used the We could also list .NET tools, which are also distributed as NuGet packages and already have some examples:
|
Thanks all... so for now, just listing here the things we'd need to think about:
|
Hey all, It does, as @AndyButland mentioned, have Umbraco as a dependency and is both a template, starter kit and component library. Please let me know if there are any steps I can take to help make this the first dotnet project template on Umbraco Marketplace. |
Did you mean "doesn't have" here @deanleigh? If you did mean "does", can you elaborate please, as clicking the link to NuGet I don't see anything that would indicate this dependency. If we can find some alternate means of validating that a package does have an Umbraco dependency, we could look to use that. Otherwise as I noted above, perhaps we have to remove or relax this check when importing packages in order to support including templates. |
The template is essentially an Umbraco site with content and doctypes added by Usync on first build.
Happy to add additional tags but not sure if that is a good long term policy. |
Not in the sense that we consider it for importing packages at the moment. If you click here you can see there are no dependencies listed. For a typical Umbraco package, e.g. here, you will see at least one (or if not, a dependency on something else that depends on Umbraco). So that's the part we have to consider/modify it allow import of templates or tools. |
This seems odd as without Umbraco there is no template.
to
Perhaps one for @LottePitcher ? |
Is there anything I can do to make this happen? |
Did you try your suggestion in the comment above? I believe if you do that - i.e. add a dependency to Umbraco CMS, and also add the usual If that works that'll at least get you the listing up. I'd still like to do a bit more to display templates and tools differently from normal packages - not least so we can display correct install instructions. But that will need work on our side - which we are talking about, but haven't yet planned in. |
Hi Andy, UmBootstrap is quite literally an Umbraco site i.e. without Umbraco it couldn't exist, so are there any instructions as to how I would go about adding Umbraco as a dependency in a way that Marketplace will recognise? |
I've made a PR to your repo to show you the idea. The important thing is that currently Umbraco CMS or Commerce must be in the dependency chain of the package, so although For background. the general instructions for listing packages are here. |
Thanks @AndyButland
I think I know how to do this manually now but I'll check your PR first |
Updated template-pack.csproj and all seems right in nuget.org. |
@deanleigh We have tools for you! 🙌 https://marketplace.umbraco.com/validate and if it passes, you can request a sync too. |
I can confirm my starterkit is now visible on the marketplace by adding the umbraco-marketplace tag and umbraco cms dependency So it is confirmed that a dotnet template starterkit can be seen in the marketplace https://marketplace.umbraco.com/package/umbcheckout.starterkit.stripe |
I have released another version, this time with umbraco-marketplace.json completed @nul800sebastiaan |
Thank you so much @AndyButland and @nul800sebastiaan for making this live. |
Yes, that's noted...
... we'll hopefully get chance to have a look at this in the upcoming weeks. |
One for Umbraco Hacktoberfest 2023? |
We've released an update today that now displays the appropriate install instructions depending on the type of package. We decided to combine what we previously had as "package type" (i.e. "Package" or "Integration") with the new detail which is the "NuGet package type" (i.e. "Package", "Tool" or "Template"). Which gives us 4 options we display on the front-end.
There's a template example here, but more will update as the synchronisation runs. |
Amazing @AndyButland thank you so much. |
@AndyButland It looks like the validator needs updating
|
I think it's actually OK, though perhaps getting a bit confusing given we have these two definitions of "package type" now that we are combining into one in the UI. But for the package owner data provided in |
There has been some discussion on Discord - https://discord.com/channels/869656431308189746/1113091087939158160 - that starter kits make more sense to be released as dotnet new templates, not umbraco packages.
What do we think about the marketplace featuring templates as well as umbraco packages? Otherwise the obvious downside to this approach is they won't be discoverable on the marketplace
This item has been added to our backlog AB#33076
The text was updated successfully, but these errors were encountered: