Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specific control types in storybook controls #537

Merged

Conversation

bjarnef
Copy link
Contributor

@bjarnef bjarnef commented Jul 18, 2023

Description

This PR makes some enhancements reported in #535

From https://storybook.js.org/docs/7.0/react/essentials/controls#choosing-the-control-type

By default, Storybook will choose a control for each arg based on the initial value of the arg. It works well with certain types of args, such as boolean values or free-text strings, but in other cases, you want a more restricted control.

In color picker we have some properties with specific values, where we can use the enum based controls instead.

I have also changes control type of value property to "color" control, which seems to work with both hex and rgba.
I updated the "With opacity" story with an initial value of rgba(0, 0, 0, 0.5) to demonstrate an initial value with opacity and the control type is set to this as well.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

image

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@github-actions
Copy link

github-actions bot commented Jul 18, 2023

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for the team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@iOvergaard iOvergaard added documentation Improvements or additions to documentation community/pr labels Jul 24, 2023
@iOvergaard
Copy link
Contributor

Looks good to me, @bjarnef! Would you run prettier on the files to make sure it passes the tests? Then I'll get it merged :)

@bjarnef
Copy link
Contributor Author

bjarnef commented Jul 24, 2023

@iOvergaard I executed npm run format.
Apparently it wants end comma although not required.

@bjarnef
Copy link
Contributor Author

bjarnef commented Aug 21, 2023

@iOvergaard any changes required for this or can it be merged? :)

@bjarnef
Copy link
Contributor Author

bjarnef commented Oct 14, 2023

Updated this with support of HSV color format in #610

@iOvergaard iOvergaard merged commit dffd063 into umbraco:v1/contrib Oct 17, 2023
4 of 6 checks passed
@bjarnef bjarnef deleted the feature/color-story-control-types branch October 17, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community/pr documentation Improvements or additions to documentation hacktoberfest/contrib-2023
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants