Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendr Settings node being overwritten when Umbraco.Workflow is installed #11

Closed
tony-gledhill opened this issue Feb 28, 2023 · 3 comments

Comments

@tony-gledhill
Copy link

Vendr: 3.0.5
Umbraco.Workflow: 10.0.0
Umbraco.CMS: 10.3.2

Installing Umbraco.Workflow into Umbraco that already has an instance of Vendr installed, causes the Vendr settings node in the admin panel to be overwritten with the Umbraco.Workflow settings node.

This means that we are unable to update the settings in Vendr

221847882-26d6a974-2b20-450b-86f4-1c99c0c830b9

@nathanwoulfe
Copy link

Hey @tony-gledhill that's a wild one! Will look into it, should be able to include the fix in the 10.1/11.1 releases next week.

@nathanwoulfe
Copy link

Interesting one this is... Looks like the issue is caused by both products including a TreeController class named SettingsTreeController, which causes confusion somewhere in Umbraco when rendering the trees. There's nothing I can see in the returned tree data (from the request to /umbraco/backoffice/umbracotrees/applicationtree/GetApplicationTrees?application=settings&tree=&use=main), but somewhere in the pipeline the Workflow tree is replacing the Vender tree.

If I rename my class to WorkflowSettingsTreeController the issue is gone, both trees work as expected.

Would be good to know why, but for now, I can include the fix in the 10.1/11.1 releases

@nathanwoulfe
Copy link

Resolved in 10.1/11.1 releases 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants