Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Video page needs to lazy load. #257

Closed
readingdancer opened this issue Jun 11, 2018 · 4 comments
Closed

The Video page needs to lazy load. #257

readingdancer opened this issue Jun 11, 2018 · 4 comments

Comments

@readingdancer
Copy link
Contributor

When clicking on the Video page you are first shown ALL videos which is currently 253 videos, this loads in the thumbnails for each of the videos which is a total page load of 9.2MB

While trying to access this page sitting in a coffee shop with share broadband is painfully slow and took over a minute for the page to load.

What I'd like to see is for this page to lazy load the video thumbnails so that the initial page load is much faster, I'm happy to take a look at this if no one else does before I get to it.

@abjerner
Copy link
Contributor

@readingdancer Good catch 👍

I think my original ideas was to have some kind of pagination as the list would grow in size. So I think that would be the ideal solution, but also requires some extra work.

Lazy loading should however be somewhat simpler - I've played around with some JavaScript, which resulted in this JSFiddle:

https://jsfiddle.net/uem4kLfs/show

Once you scroll, it detects the images (with the lazyload class) that enters the viewport. I will look into implementering that in both video lists (community and HQ).

@readingdancer
Copy link
Contributor Author

@abjerner Yes, this is exactly what I was going to implement, great you have managed to do it already :)

@umbrabot
Copy link

Hi @readingdancer,

We're writing to let you know that we've added the Up For Grabs label to your issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post

Thanks muchly, from your friendly PR team bot :-)

@nul800sebastiaan
Copy link
Member

This issue has been in the up for grabs state for quite a while now and it seems nobody is ready to pick this one up.

For now we'll close this issue to prevent the list of up for grabs from becoming very stale. We're happy to re-open it if someone still thinks it's good to work on this.

If anyone is about to pick this issue up to fix it, make sure to test first if you can reproduce the problem in the latest version before you start to work on it.

Thanks!
Sebastiaan on behalf of Umbraco HQ.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants