Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Concept for support custom extensions #13

Merged
merged 20 commits into from
Jul 15, 2019

Conversation

pvsaintpe
Copy link
Member

@pvsaintpe pvsaintpe commented Jul 13, 2019

For more information read: Readme.md and see here:
https://github.com/umbrellio/laravel-ltree

@pvsaintpe pvsaintpe added the feature New Features label Jul 13, 2019
@pvsaintpe pvsaintpe added this to the 2.2.0 milestone Jul 13, 2019
@pvsaintpe pvsaintpe self-assigned this Jul 13, 2019
@pvsaintpe
Copy link
Member Author

Схема получается примерно такой:

  • пишется кастомное расширение (оформляется отдельной репой)
  • в ней подтягивается зависимость на laravel-pg-extensions
  • описывается CustomExtension - регистр метод где в наши компоненты
    (Blueprint, Builder, PostgresConnection, PostgresGrammar, потом их будет больше) - подмешиваются методы из кастомного расширения

Таким образом получаем независимые друг от друга компоненты - которые расширяют возможности БД минуя вертикальное наследование того же Blueprint, Grammar и тд

Copy link
Member

@lazeevv lazeevv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В целом метод расширения для сторонних расширений мне нравится, надеюсь, не упремся никуда

И еще желательно на одну фичу создавать один pr. Я, например, готов апрувнуть фичу с индексами, но не могу, потому что есть вопросы по расширению

src/UmbrellioPostgresProvider.php Outdated Show resolved Hide resolved
src/Schema/Extensions/AbstractBlueprintObject.php Outdated Show resolved Hide resolved
@lazeevv
Copy link
Member

lazeevv commented Jul 14, 2019

И еще нужно readme обновить

@pvsaintpe pvsaintpe changed the title Added support for custom extensions + small feature (for index) Added Concept for support custom extensions Jul 15, 2019
README.md Outdated Show resolved Hide resolved
src/UmbrellioPostgresProvider.php Show resolved Hide resolved
src/Schema/Extensions/AbstractExtension.php Outdated Show resolved Hide resolved
@lazeevv lazeevv merged commit 3de6711 into master Jul 15, 2019
@pvsaintpe pvsaintpe deleted the feature/extensions-support branch December 20, 2020 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants