Skip to content

Commit

Permalink
Change log levels to enum
Browse files Browse the repository at this point in the history
  • Loading branch information
evgeny.iva committed Mar 23, 2023
1 parent 9a5bfe8 commit 8ab9ede
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 7 deletions.
3 changes: 2 additions & 1 deletion src/Integration/Laravel/InfluxDBLogChannel.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

use Illuminate\Log\LogManager;
use InfluxDB\Database;
use Monolog\Level;
use Monolog\Logger;
use Psr\Log\LoggerInterface;
use Umbrellio\TableSync\Monolog\Handler\InfluxDBHandler;
Expand All @@ -17,7 +18,7 @@ public function __invoke(array $config): LoggerInterface
$handler = new InfluxDBHandler(
$this->app->make(Database::class),
$config['measurement'] ?? null,
$config['level'] ?? Logger::INFO,
$config['level'] ?? Level::Info,
$config['bubble'] ?? true
);

Expand Down
3 changes: 2 additions & 1 deletion src/Integration/Laravel/TelegrafLogChannel.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
namespace Umbrellio\TableSync\Integration\Laravel;

use Illuminate\Log\LogManager;
use Monolog\Level;
use Monolog\Logger;
use Psr\Log\LoggerInterface;
use Umbrellio\TableSync\Monolog\Handler\TelegrafHandler;
Expand All @@ -17,7 +18,7 @@ public function __invoke(array $config): LoggerInterface
config('telegraf.host'),
config('telegraf.port'),
$config['measurement'] ?? null,
$config['level'] ?? Logger::INFO,
$config['level'] ?? Level::Info,
$config['bubble'] ?? true
);

Expand Down
4 changes: 2 additions & 2 deletions src/Monolog/Handler/InfluxDBHandler.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
use Monolog\Formatter\FormatterInterface;
use Monolog\Handler\AbstractProcessingHandler;
use Monolog\Handler\HandlerInterface;
use Monolog\Logger;
use Monolog\Level;
use Monolog\LogRecord;
use Umbrellio\TableSync\Monolog\Formatter\InfluxDBFormatter;
use Umbrellio\TableSync\Monolog\Formatter\TableSyncFormatter;
Expand All @@ -19,7 +19,7 @@ class InfluxDBHandler extends AbstractProcessingHandler
public function __construct(
private readonly Database $database,
private readonly string $measurement = 'table_sync',
int $level = Logger::INFO,
int|string|Level $level = Level::Info,
bool $bubble = true
) {
parent::__construct($level, $bubble);
Expand Down
4 changes: 2 additions & 2 deletions src/Monolog/Handler/TelegrafHandler.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
use InfluxDB\Driver\UDP;
use Monolog\Formatter\FormatterInterface;
use Monolog\Handler\AbstractProcessingHandler;
use Monolog\Logger;
use Monolog\Level;
use Monolog\LogRecord;
use Umbrellio\TableSync\Monolog\Formatter\InfluxDBFormatter;

Expand All @@ -19,7 +19,7 @@ public function __construct(
$host,
$port,
private readonly string $measurement = 'table_sync',
$level = Logger::INFO,
int|string|Level $level = Level::Info,
$bubble = true
) {
parent::__construct($level, $bubble);
Expand Down
3 changes: 2 additions & 1 deletion tests/unit/Logging/FormatterTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,8 @@ public function jsonTableSyncFormat(): void
$dateTime = new DateTimeImmutable();
$format = $jsonTableSyncFormatter->format($this->getDummyRecord($dateTime));
$expected = '{"datetime":"' . $dateTime->format('Y-m-d\TH:i:s.uP') .
'","message":"message","direction":"direction","routing":"routing_key","model":"model","event":"update","count":1}' . "\n";
'","message":"message","direction":"direction","routing":"routing_key",' .
'"model":"model","event":"update","count":1}' . "\n";
$this->assertIsString($format);
$this->assertSame($expected, $format);
}
Expand Down

0 comments on commit 8ab9ede

Please sign in to comment.