Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add builder and struct #3

Merged
merged 5 commits into from
Feb 3, 2019
Merged

Add builder and struct #3

merged 5 commits into from
Feb 3, 2019

Conversation

tycooon
Copy link
Member

@tycooon tycooon commented Feb 3, 2019

No description provided.

@coveralls
Copy link

coveralls commented Feb 3, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 18

  • 79 of 79 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 12: 0.0%
Covered Lines: 214
Relevant Lines: 214
💛 - Coveralls

@JelF
Copy link

JelF commented Feb 3, 2019

I think there is a lack of "integrated" usage examples / specs

I.e. a service which uses builder depending on form method, where form is a struct

@tycooon
Copy link
Member Author

tycooon commented Feb 3, 2019

You can't use forms in builders :/

@tycooon tycooon merged commit a162449 into master Feb 3, 2019
@tycooon tycooon deleted the add-new-stuff branch February 3, 2019 13:38
@JelF
Copy link

JelF commented Feb 3, 2019

You can't use forms in builders :/

:(

tycooon added a commit that referenced this pull request Jun 21, 2021
@tycooon
fix changelog #3
24240e8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelF JelF JelF approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tycooon @coveralls @JelF